[PATCH] irqchip/ti-sci-intr: Fix unsigned expression compared with zero in ti_sci_intr_alloc_parent_irq

Ye Bin yebin10 at huawei.com
Mon Aug 24 03:50:10 EDT 2020


Signed-off-by: Ye Bin <yebin10 at huawei.com>
---
 drivers/irqchip/irq-ti-sci-intr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
index cbc1758228d9..54077b66b2bd 100644
--- a/drivers/irqchip/irq-ti-sci-intr.c
+++ b/drivers/irqchip/irq-ti-sci-intr.c
@@ -144,10 +144,11 @@ static int ti_sci_intr_alloc_parent_irq(struct irq_domain *domain,
 	if (out_irq == TI_SCI_RESOURCE_NULL)
 		return -EINVAL;
 
-	p_hwirq = ti_sci_intr_xlate_irq(intr, out_irq);
-	if (p_hwirq < 0)
+	err = ti_sci_intr_xlate_irq(intr, out_irq);
+	if (err < 0)
 		goto err_irqs;
 
+	p_hwirq = err;
 	parent_node = of_irq_find_parent(dev_of_node(intr->dev));
 	fwspec.fwnode = of_node_to_fwnode(parent_node);
 
-- 
2.25.4




More information about the linux-arm-kernel mailing list