[PATCH] irqchip/ti-sci-inta: Fix unsigned expression compared with zero in ti_sci_inta_alloc_parent_irq
Ye Bin
yebin10 at huawei.com
Mon Aug 24 03:42:58 EDT 2020
Signed-off-by: Ye Bin <yebin10 at huawei.com>
---
drivers/irqchip/irq-ti-sci-inta.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index d4e97605456b..37d09cbdc15c 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -182,12 +182,13 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
if (vint_id == TI_SCI_RESOURCE_NULL)
return ERR_PTR(-EINVAL);
- p_hwirq = ti_sci_inta_xlate_irq(inta, vint_id);
- if (p_hwirq < 0) {
- ret = p_hwirq;
+ ret = ti_sci_inta_xlate_irq(inta, vint_id);
+ if (ret < 0) {
goto free_vint;
}
+ p_hwirq = ret;
+
vint_desc = kzalloc(sizeof(*vint_desc), GFP_KERNEL);
if (!vint_desc) {
ret = -ENOMEM;
--
2.25.4
More information about the linux-arm-kernel
mailing list