[PATCH] drivers/perf: arm_pmu: Show PMU version on boot

Will Deacon will at kernel.org
Fri Aug 21 12:03:05 EDT 2020


On Thu, Jul 30, 2020 at 06:47:21PM +0800, Shaokun Zhang wrote:
> The @pmuver field has been initialized and can tell the PMU version.
> Let's show it on boot and the user obtains this information directly.
> 
> Cc: Will Deacon <will at kernel.org>
> Cc: Mark Rutland <mark.rutland at arm.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun at hisilicon.com>
> ---
>  drivers/perf/arm_pmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index df352b334ea7..36f7fad7ba5a 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -870,8 +870,8 @@ int armpmu_register(struct arm_pmu *pmu)
>  	if (!__oprofile_cpu_pmu)
>  		__oprofile_cpu_pmu = pmu;
>  
> -	pr_info("enabled with %s PMU driver, %d counters available\n",
> -		pmu->name, pmu->num_events);
> +	pr_info("enabled with %s PMU driver, %d counters available, version is %d\n",
> +		pmu->name, pmu->num_events, pmu->pmuver);

Hmm. I'm suspicious about this. Who is using this, and what for? We're
better off exposing things in the existing sysfs directory we have if it's
actually needed by tools.

Will



More information about the linux-arm-kernel mailing list