[PATCH v2 1/4] ARM: imx7d: add enet2 clk sel

[Shawn Guo]

On Tue, Jul 14, 2020 at 07:11:37AM +0200, Steffen Trumtrar wrote:
> Add clock source init for the second ethernet port.
> This changes the clock direction and clock selection in a way that the
> ethernet phy reference clock is routed as an output.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar at pengutronix.de>
> ---
>  arch/arm/mach-imx/mach-imx7d.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/mach-imx7d.c b/arch/arm/mach-imx/mach-imx7d.c
> index 879c35929a13..7a203f660721 100644
> --- a/arch/arm/mach-imx/mach-imx7d.c
> +++ b/arch/arm/mach-imx/mach-imx7d.c
> @@ -65,6 +65,9 @@ static void __init imx7d_enet_clk_sel(void)
>  	if (!IS_ERR(gpr)) {
>  		regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_TX_CLK_SEL_MASK, 0);
>  		regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_CLK_DIR_MASK, 0);
> +		regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_TX_CLK_SEL_MASK, 0);
> +		regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_CLK_DIR_MASK,
> +				   IMX7D_GPR1_ENET2_CLK_DIR_MASK);

I would like to see such code get removed from machine code rather than
added.  Can we deal with these IOMUXC_GPR bits in some driver code?

Shawn

>  	} else {
>  		pr_err("failed to find fsl,imx7d-iomux-gpr regmap\n");
>  	}
> -- 
> 2.27.0
>