[PATCH] ARM: compress: Fix the debug prints

Russell King - ARM Linux admin linux at armlinux.org.uk
Fri Aug 7 08:59:08 EDT 2020


On Fri, Aug 07, 2020 at 02:26:56PM +0200, Linus Walleij wrote:
> @@ -49,8 +49,10 @@
>  
>  #include CONFIG_DEBUG_LL_INCLUDE
>  
> -		.macro	writeb,	ch, rb
> +		.macro	writeb,	ch, rb, tmp
> +		waituart \tmp, \rb
>  		senduart \ch, \rb
> +		busyuart \tmp, \rb
>  		.endm

This could likely cause problems.

waituart does things such as waiting for CTS to be asserted, and we
really don't want to block the decompressor if CTS is deasserted.

busyuart should be mostly fine though, provided the UART is actually
functional.

We haven't used either of these, we've relied on a software loop to
wait some time before queueing the next character.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!



More information about the linux-arm-kernel mailing list