[PATCH v7 16/25] coresight: allow funnel and replicator drivers to be built as modules

Tingwei Zhang tingweiz at codeaurora.org
Wed Aug 5 22:55:54 EDT 2020


On Thu, Aug 06, 2020 at 12:04:24AM +0800, Suzuki K Poulose wrote:
> On 08/05/2020 03:54 AM, Tingwei Zhang wrote:
> >From: Kim Phillips <kim.phillips at arm.com>
> >
> >Allow to build coresight-funnel and coresight-replicator as modules,
> >for ease of development.
> >
> >- Kconfig becomes a tristate, to allow =m
> >- add funnel_remove and replicator_remove functions,
> >   for module unload
> >- add a MODULE_DEVICE_TABLE for autoloading on boot
> >
> >Cc: Mathieu Poirier <mathieu.poirier at linaro.org>
> >Cc: Leo Yan <leo.yan at linaro.org>
> >Cc: Alexander Shishkin <alexander.shishkin at linux.intel.com>
> >Cc: Randy Dunlap <rdunlap at infradead.org>
> >Cc: Suzuki K Poulose <Suzuki.Poulose at arm.com>
> >Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> >Cc: Russell King <linux at armlinux.org.uk>
> >Signed-off-by: Kim Phillips <kim.phillips at arm.com>
> >Signed-off-by: Tingwei Zhang <tingwei at codeaurora.org>
> >Tested-by: Mike Leach <mike.leach at linaro.org>
> 
> nit: Please split the changes to multiple drivers into their respective
> patches. Also, I don't see any harm in merging the "remove multiple init
> calls" patches with the respective "allow module" for the respective
> drivers.
I'll rearrange the patches.

Thanks,
Tingwei
> 
> Otherwise looks good to me.
> 
> Suzuki



More information about the linux-arm-kernel mailing list