[PATCH v2 01/13] clk: samsung: s3c64xx: declare s3c64xx_clk_init() in shared header

[Chanwoo Choi]

Hi Krzysztof,

On 8/5/20 4:26 AM, Krzysztof Kozlowski wrote:
> The s3c64xx_clk_init() is defined and used by the clk-s3c64xx driver and
> also used in the mach-s3c64xx machine code.  Move the declaration to a
> header to fix W=1 build warning:
> 
>     drivers/clk/samsung/clk-s3c64xx.c:391:13: warning: no previous prototype for 's3c64xx_clk_init' [-Wmissing-prototypes]
>       391 | void __init s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f,
> 
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
> Reviewed-by: Tomasz Figa <tomasz.figa at gmail.com>
> 
> ---
> 
> Changes since v1:
> 1. Drop __init from header (as suggested by Stephen),
> 2. Add necessary header and forward declaration (as suggested by
>    Stephen),
> 3. Add review tag.
> ---
>  MAINTAINERS                       |  1 +
>  arch/arm/mach-s3c64xx/common.c    |  1 +
>  arch/arm/mach-s3c64xx/common.h    |  2 --
>  drivers/clk/samsung/clk-s3c64xx.c |  1 +
>  include/linux/clk/samsung.h       | 24 ++++++++++++++++++++++++
>  5 files changed, 27 insertions(+), 2 deletions(-)
>  create mode 100644 include/linux/clk/samsung.h
> 

(snip)

Looks good to me. Thanks.

Acked-by: Chanwoo Choi <cw00.choi at samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics