[PATCH] drm/vc4: Use 16bpp by default for the fbdev buffer

Paul Kocialkowski paul.kocialkowski at bootlin.com
Wed Mar 6 07:06:44 PST 2019


On Wed, 2019-03-06 at 15:02 +0100, Maxime Ripard wrote:
> The preferred bpp for the fbdev emulation buffer has been 32 so far, which
> means that by default we will allocate an 8MB buffer with a 1920x1080
> resolution.
> 
> Worse this memory will be allocated from the CMA pool, and will never be
> freed even if we don't use the fbdev emulation. Therefore, reducing it is a
> big deal, and switching to 16bpp by default will gain us around 4MB at
> 1920x1080, while keeping decent color depth. And users still have the
> option to switch to 32bpp using the kernel command line.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard at bootlin.com>

Reviewed-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>

Cheers,

Paul

> ---
>  drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 52576dee809e..c38cf64837e1 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -286,7 +286,7 @@ static int vc4_drm_bind(struct device *dev)
>  
>  	vc4_kms_load(drm);
>  
> -	drm_fbdev_generic_setup(drm, 32);
> +	drm_fbdev_generic_setup(drm, 16);
>  
>  	return 0;
>  
-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com




More information about the linux-arm-kernel mailing list