[PATCH] pinctrl: mediatek: fix check on EINT_NA comparison

Linus Walleij linus.walleij at linaro.org
Wed Sep 26 00:42:00 PDT 2018


On Tue, Sep 25, 2018 at 11:55 AM Colin King <colin.king at canonical.com> wrote:

> From: Colin Ian King <colin.king at canonical.com>
>
> Currently, the check on desc->eint.eint_n == EINT_NA is always false
> because this is comparing a u16 to -1 which can never be true.  Fix
> this by casting EINT_NA to u16.
>
> Detected by CoverityScan, CID#1473610 ("Operands don't affect result")
>
> Fixes: fb5fa8dc151b ("pinctrl: mediatek: extend struct mtk_pin_desc to pinctrl-mtk-common-v2.c")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Patch applied.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list