[PATCH v7 1/7] edac: synopsys: Fix code comments and naming convention
MNARANI at xilinx.com
Tue Sep 18 22:08:50 PDT 2018
Thanks a lot for the review.
> -----Original Message-----
> From: Borislav Petkov [mailto:bp at alien8.de]
> Sent: Tuesday, September 18, 2018 1:23 PM
> To: Manish Narani <MNARANI at xilinx.com>
> Cc: robh+dt at kernel.org; mark.rutland at arm.com; mchehab at kernel.org;
> Michal Simek <michals at xilinx.com>; leoyang.li at nxp.com;
> sudeep.holla at arm.com; amit.kucheria at linaro.org;
> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
> edac at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH v7 1/7] edac: synopsys: Fix code comments and naming
> On Mon, Sep 17, 2018 at 07:54:59PM +0530, Manish Narani wrote:
> > Update the comments in the Synopsys EDAC driver. Minor changes to
> > function names and return types are also included.
> > Signed-off-by: Manish Narani <manish.narani at xilinx.com>
> > ---
> > drivers/edac/synopsys_edac.c | 176
> > ++++++++++++++++++++-----------------------
> > 1 file changed, 80 insertions(+), 96 deletions(-)
> So this patch does a bunch of things together and should be split into:
> * functional changes like code cleanup
> * functions renaming
> * comments cleanup
> Maybe in that order.
> This way you'll have one logical set of changes per patch and review will be
> almost trivial.
Okay, I will do that in v8.
More information about the linux-arm-kernel