[PATCH] arm64: dts: renesas: r8a774a1: Add CAN nodes

Fabrizio Castro fabrizio.castro at bp.renesas.com
Mon Sep 10 02:56:18 PDT 2018


Hello Geert,

Thank you for your feedback.

> Subject: Re: [PATCH] arm64: dts: renesas: r8a774a1: Add CAN nodes
>
> Hi Fabrizio,
>
> On Thu, Aug 23, 2018 at 4:22 PM Fabrizio Castro
> <fabrizio.castro at bp.renesas.com> wrote:
> > From: Chris Paterson <chris.paterson2 at renesas.com>
> >
> > Add the device nodes for both RZ/G2M CAN channels.
> >
> > Signed-off-by: Chris Paterson <chris.paterson2 at renesas.com>
> > Reviewed-by: Biju Das <biju.das at bp.renesas.com>
> > ---
> >
> > This patch depends on:
> > https://lkml.org/lkml/2018/8/23/1049
> > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg30550.html
> >
> >
> >  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > index 5d0109a..cd204f5 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > @@ -816,6 +816,30 @@
> >                         status = "disabled";
> >                 };
> >
> > +               can0: can at e6c30000 {
> > +                       compatible = "renesas,can-r8a774a1",
> > +                                    "renesas,rzg-gen2-can";
>
> Please don't introduce "renesas,rzg-gen2-can", cfr. my comments in
> https://lore.kernel.org/lkml/CAMuHMdWPuqfXOgh_-qp8q6wATU3Lj_WpX0bAOxPBX76SKvyXCQ@mail.gmail.com/

Agreed, will send a v2.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.


More information about the linux-arm-kernel mailing list