[PATCH v2 3/3] ARM: OMAP1: ams-delta: register MODEM device earlier
jmkrzyszt at gmail.com
Sun Sep 9 16:44:19 PDT 2018
Amstrad Delta MODEM device used to be initialized at arch_initcall
before it was once moved to late_initcall by commit f7519d8c8290 ("ARM:
OMAP1: ams-delta: register latch dependent devices later"). The purpose
of that change was to postpone initialization of devices which depended
on latch2 pins until latch2 converted to GPIO device was ready.
After recent fixes to GPIO handling, it was possible to moove
registration of most of those device back to where they were before.
The same can be safely done with the MODEM device as initialization
of GPIO pins it depends on was moved to machine_init by preceding
Move registration of the MODEM device to arch_initcall_sync, not to
arch_initcall, so it is never exposed to potential conflict in
registration order hazard against OMAP serial ports.
Signed-off-by: Janusz Krzysztofik <jmkrzyszt at gmail.com>
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
arch/arm/mach-omap1/board-ams-delta.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index 1d451142248c..667c3c1f05f5 100644
@@ -896,11 +896,28 @@ static int __init modem_nreset_init(void)
* This function expects MODEM IRQ number already assigned to the port
* and fails if it's not.
+ * The MODEM device requires its RESET# pin kept high during probe.
+ * That requirement can be fulfilled in several ways:
+ * - with a descriptor of already functional modem_nreset regulator
+ * assigned to the MODEM private data,
+ * - with the regulator not yet controlled by modem_pm function but
+ * already enabled by default on probe,
+ * - before the modem_nreset regulator is probed, with the pin already
+ * set high explicitly.
+ * The last one is already guaranteed by ams_delta_latch2_init() called
+ * from machine_init.
+ * In order to avoid taking over ttyS0 device slot, the MODEM device
+ * should be registered after OMAP serial ports. Since those ports
+ * are registered at arch_initcall, this function can be called safely
+ * at arch_initcall_sync earliest.
static int __init ams_delta_modem_init(void)
+ if (!machine_is_ams_delta())
+ return -ENODEV;
if (ams_delta_modem_ports.irq < 0)
@@ -913,6 +930,7 @@ static int __init ams_delta_modem_init(void)
static int __init late_init(void)
@@ -922,10 +940,6 @@ static int __init late_init(void)
- err = ams_delta_modem_init();
- if (err)
- return err;
* Once the modem device is registered, the modem_nreset
* regulator can be requested on behalf of that device.
More information about the linux-arm-kernel