[PATCH 1/3] dt-bindings: change the A64 HDMI PHY binding to R40

Maxime Ripard maxime.ripard at bootlin.com
Wed Sep 5 00:56:01 PDT 2018


On Wed, Sep 05, 2018 at 03:46:41PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2018年9月5日 GMT+08:00 下午3:14:35, Maxime Ripard <maxime.ripard at bootlin.com> 写到:
> >On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote:
> >> By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux
> >> introduced in R40, although it has two PLL-VIDEOs.
> >> 
> >> Change the A64 HDMI PHY binding to R40 one.
> >> 
> >> This binding is introduced in v4.19, which is still in RC stage, so
> >we
> >> have change to fix it.
> >> 
> >> Signed-off-by: Icenowy Zheng <icenowy at aosc.io>
> >
> >That doesn't make much sense. The A64 doesn't have any particular
> >reason to behave like the R40, and the R40 can definitely use a
> >different compatible if it has a different behaviour. But I don't see
> >*why* the A64 not behaving like the R40 is a justification to remove
> >the A64 compatible. Especially when the R40 was released later.
> >
> >Add a new compatible, and leave the A64 compatible alone.
> 
> But the behavior of A64 compatible will change from double
> PLL to single PLL, because the A64 HDMI PHY is proven
> to have no double PLL.
> 
> Should I then change the A64 compatible behavior and import R40
> compatible at the same time?

I don't see why you should do both at the same time. Fix the A64, and
add the support for the R40, those are two orthogonal changes.

> In addition maybe I can just drop A64 compatible, and let A64
> use H3 one.

No, that break the backward compatibility.

Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180905/96a447bd/attachment.sig>


More information about the linux-arm-kernel mailing list