[PATCH] arm64: dts: juno: fix graph node unit addresses for coresight components

Sudeep Holla sudeep.holla at arm.com
Wed May 16 04:49:25 PDT 2018



On 16/05/18 12:23, Suzuki K Poulose wrote:
> On 05/16/2018 11:34 AM, Sudeep Holla wrote:

[..]

>> Hi Suzuki/Mathieu,
>>
>> I did a quick scan @ drivers/hwtracing/coresight/of_coresight.c to
>> check if reg field is being used or not and whether this change
>> causes any regression. I don't think so, but I may be wrong, let me
>> know.
> 
> Unfortunately, I think this would break the components like funnel,
> where we need the input port number for the connected master to enable
> the port. Similarly for the output port number for master components in
> the paths. I have a set of patches which address this by taking care of
> the port number order to find out the hardware port number.
> 

Ah ok, I now see of_graph_parse_endpoint, sorry for missing that.

> I will dust it up and send it. That would bring up another important
> question.
> 

Cool

> How do we deal with the change in the port number scheme ? e.g, should
> the new kernel support DTBs with old scheme ? 

IIUC, that's needed for backward compatibility as it was used schema.
Again I may be wrong.

> If so, how do we specify that the DT uses new scheme.

Perhaps, add something to indicate the change in numbering scheme ?

-- 
Regards,
Sudeep



More information about the linux-arm-kernel mailing list