reply: [PATCH v3 1/2] PCI: kirin: Add MSI support

[songxiaowei]

Hi, Andy Shevchenko

Yao is on maternity leave, and I'll take over the job after discussing with her.

> -----邮件原件-----
> 发件人: Andy Shevchenko [mailto:andy.shevchenko at gmail.com]
> 发送时间: 2018年5月14日 7:16
> 收件人: chenyao (F) <chenyao11 at huawei.com>
> 抄送: songxiaowei <songxiaowei at hisilicon.com>; Wangbinghui
> <wangbinghui at hisilicon.com>; Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>;
> Bjorn Helgaas <bhelgaas at google.com>; xuwei (O) <xuwei5 at huawei.com>;
> Rob Herring <robh+dt at kernel.org>; Mark Rutland <mark.rutland at arm.com>;
> Catalin Marinas <catalin.marinas at arm.com>; Will Deacon
> <will.deacon at arm.com>; linux-pci at vger.kernel.org; Linux Kernel Mailing List
> <linux-kernel at vger.kernel.org>; linux-arm Mailing List
> <linux-arm-kernel at lists.infradead.org>; devicetree
> <devicetree at vger.kernel.org>; dimitrysh at google.com;
> guodong.xu at linaro.org; Suzhuangluan <suzhuangluan at hisilicon.com>; Kongfei
> <kongfei at hisilicon.com>
> 主题: Re: [PATCH v3 1/2] PCI: kirin: Add MSI support
> 
> On Fri, May 11, 2018 at 12:15 PM, Yao Chen <chenyao11 at huawei.com> wrote:
> > Add support for MSI.
> 
> 
> > +       int ret;
> > +
> > +       if (IS_ENABLED(CONFIG_PCI_MSI)) {
> 
> > +               pci->pp.msi_irq = platform_get_irq(pdev, 0);
> > +               if (pci->pp.msi_irq < 0) {
> > +                       dev_err(&pdev->dev, "failed to get MSI IRQ
> (%d)\n",
> > +                               pci->pp.msi_irq);
> 
> > +                       return -ENODEV;
> 
> Why shadowing actual error code?
[songxiaowei]  Sorry, I can't get your point about this, would you explain it for me.
> 
> > +               }
> > +               ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq,
> > +                                      kirin_pcie_msi_irq_handler,
> > +                                      IRQF_SHARED |
> IRQF_NO_THREAD,
> > +                                      "kirin_pcie_msi", &pci->pp);
> > +               if (ret) {
> > +                       dev_err(&pdev->dev, "failed to request MSI
> IRQ %d\n",
> > +                               pci->pp.msi_irq);
> > +                       return ret;
> > +               }
> 
> It would be easy to read and maintain if this would be a separate function.
[songxiaowei] Yes, a separate function will be better, and I'll fix it.
> 
> > +       }
> 
> 
> 
> --
> With Best Regards,
> Andy Shevchenko

Thanks a lot,

Best Regards,
Xiaowei Song