[PATCH 3/9] soc: fsl: set rcpm bit for FTM

Leo Li leoyang.li at nxp.com
Fri May 11 10:00:28 PDT 2018



> -----Original Message-----
> From: Yinbo Zhu [mailto:yinbo.zhu at nxp.com]
> Sent: Thursday, May 10, 2018 10:35 PM
> To: Yinbo Zhu <yinbo.zhu at nxp.com>; Rob Herring <robh+dt at kernel.org>;
> Mark Rutland <mark.rutland at arm.com>; Catalin Marinas )
> <catalin.marinas at arm.com>; Will Deacon ) <will.deacon at arm.com>;
> Lorenzo Pieralisi ) <lorenzo.pieralisi at arm.com>; Leo Li <leoyang.li at nxp.com>
> Cc: Xiaobo Xie <xiaobo.xie at nxp.com>; Ran Wang <ran.wang_1 at nxp.com>;
> Daniel Lezcano <daniel.lezcano at linaro.org>; Thomas Gleixner
> <tglx at linutronix.de>; Shawn Guo <shawnguo at kernel.org>; Madalin-cristian
> Bucur <madalin.bucur at nxp.com>; Z.q. Hou <zhiqiang.hou at nxp.com>; Jerry
> Huang <jerry.huang at nxp.com>; M.h. Lian <minghuan.lian at nxp.com>;
> Qiang Zhao <qiang.zhao at nxp.com>; Fabio Estevam
> <fabio.estevam at nxp.com>; Jiaheng Fan <jiaheng.fan at nxp.com>; Po Liu
> <po.liu at nxp.com>; Nipun Gupta <nipun.gupta at nxp.com>; Horia Geantă
> <horia.geanta at nxp.com>; Priyanka Jain <priyanka.jain at nxp.com>; Sumit
> Garg <sumit.garg at nxp.com>; costi <constantin.tudor at freescale.com>;
> Bogdan Purcareata <bogdan.purcareata at nxp.com>; Meng Yi
> <meng.yi at nxp.com>; Wang Dongsheng <dongsheng.wang at nxp.com>; open
> list:CLOCKSOURCE, CLOCKEVENT DRIVERS <linux-kernel at vger.kernel.org>;
> open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree at vger.kernel.org>; linux-arm-kernel at lists.infradead.org; open
> list:FREESCALE SOC DRIVERS <linuxppc-dev at lists.ozlabs.org>; Andy Tang
> <andy.tang at nxp.com>; Ying Zhang <ying.zhang22455 at nxp.com>
> Subject: [PATCH 3/9] soc: fsl: set rcpm bit for FTM
> 
> From: Zhang Ying-22455 <ying.zhang22455 at nxp.com>
> 
> Set RCPM for FTM when using FTM as wakeup source. Because the RCPM
> module of each platform has different big-end and little-end mode, there
> need to set RCPM depending on the platform.
> 
> Signed-off-by: Zhang Ying-22455 <ying.zhang22455 at nxp.com>
> Signed-off-by: Yinbo Zhu <yinbo.zhu at nxp.com>
> ---
>  .../devicetree/bindings/timer/fsl,ftm-timer.txt    |    7 ++
>  drivers/soc/fsl/layerscape/ftm_alarm.c             |   92 ++++++++++++++++++-
>  2 files changed, 94 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> index aa8c402..15ead58 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> @@ -3,6 +3,13 @@ Freescale FlexTimer Module (FTM) Timer  Required
> properties:
> 
>  - compatible : should be "fsl,ftm-timer"

Hi Yingbo,

This is a change that breaks backward compatibility and not acceptable.

> + Possible compatibles for ARM:
> +     "fsl,ls1012a-ftm"
> +     "fsl,ls1021a-ftm"
> +     "fsl,ls1043a-ftm"
> +     "fsl,ls1046a-ftm"
> +     "fsl,ls1088a-ftm"
> +     "fsl,ls208xa-ftm"
>  - reg : Specifies base physical address and size of the register sets for the
>    clock event device and clock source device.
>  - interrupts : Should be the clock event device interrupt.
> diff --git a/drivers/soc/fsl/layerscape/ftm_alarm.c
> b/drivers/soc/fsl/layerscape/ftm_alarm.c
> index 6f9882f..811dcfa 100644
> --- a/drivers/soc/fsl/layerscape/ftm_alarm.c
> +++ b/drivers/soc/fsl/layerscape/ftm_alarm.c

There is no such file in the mainline kernel.  So it looks like the patch set is based on some internal git repo instead of the upstream Linux kernel.  This kind of patches shouldn't be sent to the upstream mailing list for review.

Regards,
Leo




More information about the linux-arm-kernel mailing list