[PATCH 01/21] dt-bindings: clock: Add compatible for A64 DE2 CCU

[Rob Herring]

On Tue, May 1, 2018 at 11:19 AM, Chen-Yu Tsai <wens at csie.org> wrote:
> On Wed, May 2, 2018 at 12:16 AM, Rob Herring <robh at kernel.org> wrote:
>> On Mon, Apr 30, 2018 at 05:10:38PM +0530, Jagan Teki wrote:
>>> Allwinner A64 has DE2 CCU which is similar to H3/H5 SoC.
>>>
>>> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
>>> ---
>>>  Documentation/devicetree/bindings/clock/sun8i-de2.txt | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Rob Herring <robh at kernel.org>
>
> Hi Rob,
>
> Do we need to add this if it's just a soc-specific compatible
> we add in the device tree to future proof things in case we
> discover quirks later on?

Yes, but the fallbacks should be documented too as I found in the rest
of the series.

> AFAIK we haven't been doing this, and this is likely to create
> some confusion, because they aren't actually mentioned anywhere
> in the driver.

The binding doc needs to written such that compatible can be validated
to contain the correct set of strings. We can't do that now with free
form text, but when we move to a schema we will.

Rob