[PATCHv2] pinctrl: samsung: add pin_dbg_show callback for debugfs

Krzysztof Kozlowski krzk at kernel.org
Wed Mar 28 03:23:47 PDT 2018


On Tue, Mar 27, 2018 at 3:58 PM, Chanho Park <parkch98 at gmail.com> wrote:
> This patch adds a samsung_pin_dbg_show function to implement the
> pin_dbg_show callback function which can be used to show pin
> confuration values. Basically, it can show pin setting values by
> accessing the "pins" node like below:
>
> $ cat pins
> pin 0 (gpy7-0)  CON(0x0) DAT(0x1) PUD(0x1) DRV(0x0) CON_PDN(0x0) PUD_PDN(0x0)
>
> Signed-off-by: Chanho Park <parkch98 at gmail.com>
> ---
> Changes from v1:
> - use samsung_pinconf_get instead of samsung_pinconf_rw
> - use "static const char * const" type declaration of reg_names
> - skip condition change
>
>  drivers/pinctrl/samsung/pinctrl-samsung.c | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

Looks fine, thanks:
Reviewed-by: Krzysztof Kozlowski <krzk at kernel.org>

Linus,
I do not have anything in my pinctrl queue for you so maybe you can
take it directly? Otherwise, I will apply it after upcoming merge
window.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list