[PATCH 1/2] regulator: add QCOM RPMh regulator driver

Lina Iyer ilina at codeaurora.org
Mon Mar 26 08:35:20 PDT 2018


On Thu, Mar 22 2018 at 19:30 -0600, David Collins wrote:
>Hello Stephen,
>
>Thank you for the very detailed review feedback.
>
>On 03/21/2018 12:07 PM, Stephen Boyd wrote:
>> Quoting David Collins (2018-03-16 18:09:10)

>>> +static int rpmh_regulator_remove(struct platform_device *pdev)
>>> +{
>>> +       struct rpmh_pmic *pmic = platform_get_drvdata(pdev);
>>> +
>>> +       rpmh_release(pmic->rpmh_client);
>>
>> I'm still lost on what rpmh_client is giving us besides more code we
>> don't need. I'll ping the rpmh thread again.
>
>Let's see if Lina is willing to add some devm_* calls so that no cleanup
>is required.
>
I will look into this.

-- Lina




More information about the linux-arm-kernel mailing list