[PATCH v3 2/3] gpiolib: Support 'gpio-reserved-ranges' property
Stephen Boyd
swboyd at chromium.org
Wed Mar 21 12:59:05 PDT 2018
Quoting Andy Shevchenko (2018-03-21 10:59:10)
> On Wed, 2018-03-21 at 09:58 -0700, Stephen Boyd wrote:
> > From: Stephen Boyd <sboyd at codeaurora.org>
> >
> > Some qcom platforms make some GPIOs or pins unavailable for use by
> > non-secure operating systems, and thus reading or writing the
> > registers
> > for those pins will cause access control issues. Add support for a DT
> > property to describe the set of GPIOs that are available for use so
> > that
> > higher level OSes are able to know what pins to avoid reading/writing.
> > Non-DT platforms can add support by directly updating the
> > chip->valid_mask.
>
> > Signed-off-by: Stephen Boyd <sboyd at codeaurora.org>
> > Signed-off-by: Stephen Boyd <swboyd at chromium.org>
>
> Hmm...
Don't look closely! :P
>
> > + gpiochip->valid_mask = kcalloc(BITS_TO_LONGS(gpiochip-
> > >ngpio),
> > + sizeof(long), GFP_KERNEL);
>
> Just noticed that kcalloc is superfluous here.
> kmalloc_array() would be enough.
>
Ok. I was copying the irqchip style. Should I fold them together into a
helper function and also update to kmalloc_array?
More information about the linux-arm-kernel
mailing list