[PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

Anson Huang anson.huang at nxp.com
Sun Mar 18 19:09:39 PDT 2018


Hi, Fabio

Anson Huang
Best Regards!


> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Sunday, March 18, 2018 9:04 PM
> To: Anson Huang <anson.huang at nxp.com>
> Cc: Shawn Guo <shawnguo at kernel.org>; Sascha Hauer
> <kernel at pengutronix.de>; Fabio Estevam <fabio.estevam at nxp.com>; Rob
> Herring <robh+dt at kernel.org>; Mark Rutland <mark.rutland at arm.com>;
> Russell King - ARM Linux <linux at armlinux.org.uk>; Michael Turquette
> <mturquette at baylibre.com>; Stephen Boyd <sboyd at kernel.org>; S.j. Wang
> <shengjiu.wang at nxp.com>; dl-linux-imx <linux-imx at nxp.com>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel at lists.infradead.org>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree at vger.kernel.org>; linux-kernel
> <linux-kernel at vger.kernel.org>; linux-clk <linux-clk at vger.kernel.org>
> Subject: Re: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock
> source
> 
> On Sun, Mar 18, 2018 at 12:14 AM, Anson Huang <Anson.Huang at nxp.com>
> wrote:
> 
> > diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > index 72da5ac..83f7cac 100644
> > --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> > @@ -18,6 +18,14 @@
> >                 reg = <0x80000000 0x80000000>;
> >         };
> >
> > +       clocks {
> > +               codec_osc: anaclk2 {
> > +                       #clock-cells = <0>;
> > +                       compatible = "fixed-clock";
> > +                       clock-frequency = <24576000>;
> > +               };
> > +       };
> 
> The clocks container should be removed and the clock node could be put directly
> into the root node.
> 
> Also, I do not see 'codec_osc' being used in this dts.
 
This clock will be used by cs42888 codec, this patch is only to add basic clock source
to complete the clock tree. Thanks.

Anson.


More information about the linux-arm-kernel mailing list