[PATCH v7] ARM: shmobile: Add watchdog support

Simon Horman horms at verge.net.au
Fri Mar 16 04:49:01 PDT 2018


On Wed, Mar 14, 2018 at 01:26:52PM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> > Subject: Re: [PATCH v7] ARM: shmobile: Add watchdog support
> >
> > On Wed, Mar 14, 2018 at 11:13:53AM +0000, Fabrizio Castro wrote:
> > > On R-Car Gen2 and RZ/G1 platforms, we use the SBAR registers to make non
> > > boot CPUs run a routine designed to bring up SMP and deal with hot plug.
> > > The value contained in the SBAR registers is not initialized by a WDT
> > > triggered reset, which means that after a WDT triggered reset we jump
> > > to the SMP bring up routine, preventing the system from executing the
> > > bootrom code.
> > >
> > > The purpose of this patch is to jump to the bootrom code in case of a
> > > WDT triggered reset, and keep the SMP functionality untouched.
> > > In order to tell if the code had been called due to the WDT overflowing
> > > we are testing WOVF from register RWTCSRA.
> > >
> > > The new function shmobile_boot_vector_gen2 isn't replacing
> > > shmobile_boot_vector for backward compatibility reasons. The kernel
> > > will install the best option (either shmobile_boot_vector or
> > > shmobile_boot_vector_gen2) to ICRAM1 after parsing the device tree,
> > > according to the amount of memory available.
> > >
> > > Since shmobile_boot_vector has become bigger, "reg" property of nodes
> > > compatible with "renesas,smp-sram" now need to be set to a value
> > > greater or equal to "<0 0x60>".
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro at bp.renesas.com>
> > > Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram at bp.renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
> > > ---
> > > v6->v7:
> > > * restored ifdef within arch/arm/mach-shmobile/headsmp.S
> >
> > Thanks. I believe that this is the same as the hand modified
> > version of v5 that I applied yesterday.
> 
> yes, I believe v5 modified and applied by you is the same as v7.
> Thank you for taking the patch.

Likewise, thanks for the patches and for confirming this one is correct.



More information about the linux-arm-kernel mailing list