[PATCH] soc: imx: gpc: Use kemdup() function
Shawn Guo
shawnguo at kernel.org
Wed Mar 14 20:13:18 PDT 2018
Hi Fabio,
On Sun, Mar 11, 2018 at 08:19:42PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
>
> Use kmemdup() rather than duplicating its implementation.
>
> Detected with Coccinelle script.
>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
I copied you on my reply to Andrey Smirnov, in which I requested to
use platform_device_add_data() for his patches. That said, your patches
will be dropped as well.
Shawn
> ---
> drivers/soc/imx/gpc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 196f17b..cc3bad8 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -444,12 +444,12 @@ static int imx_gpc_probe(struct platform_device *pdev)
> if (domain_index >= of_id_data->num_domains)
> continue;
>
> - domain = kmalloc(sizeof(*domain), GFP_KERNEL);
> + domain = kmemdup(&imx_gpc_domains[domain_index],
> + sizeof(*domain), GFP_KERNEL);
> if (!domain) {
> of_node_put(np);
> return -ENOMEM;
> }
> - memcpy(domain, &imx_gpc_domains[domain_index], sizeof(*domain));
> domain->regmap = regmap;
> domain->ipg_rate_mhz = ipg_rate_mhz;
>
> --
> 2.7.4
>
More information about the linux-arm-kernel
mailing list