PSCI version misdetection

[Mark Rutland]

On Mon, Mar 12, 2018 at 08:12:02AM -0300, Fabio Estevam wrote:
> Hi Mark,
> 
> On Mon, Mar 12, 2018 at 7:02 AM, Mark Rutland <mark.rutland at arm.com> wrote:
> 
> > It sounds like U-Boot hasn't implemented the PSCI_VERSION call, and is
> > returning NOT_IMPLEMENTED (-1). If so, this is not a conforming PSCI 1.0
> > implementation, as PSCI_VERSION is mandatory.
> >
> > AFAICT, The default implementation in arch/arm/cpu/armv7/psci.S returns
> > NOT_SUPPORTED.
> >
> > Where does the implementation for imx7d-sdb live? Is this upstream?
> 
> Yes, it is in mainline U-Boot.
> 
> As per this commit it would use PSCIv1.0:
> 
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=0ec3d98f76923619acfd91f93f8221e609e1e5bc;hp=04c28a7810970e404550f3510f8d9dfd90d6dc81

Ok. AFAICT, you need to implement psci_version, and any other mandatory
PSCI features such as affinity info in your board code, as otherwise the
default weak implementation is used.

Defining CONFIG_ARMV7_PSCI_1_0 alone is not sufficient, and I would
strongly recommend reverting the above commit until those functions are
implemented. There is no benefit to an incomplete and non-conforming
PSCI 1.0, and this will cause problems.

I believe that also applies to the uniphier platform code, judging by
include/configs/uniphier.h.

Thanks,
Mark.