[PATCH] ARM64: dts: marvell: armada-cp110: Add registers clock for SPI nodes

[Baruch Siach]

Hi Gregory,

On Tue, Jan 30, 2018 at 01:21:38PM +0200, Baruch Siach wrote:
> On Tue, Jan 30, 2018 at 12:14:55PM +0100, Gregory CLEMENT wrote:
> > This extra clock is needed to access the registers of the SPI controller
> > used on Armada 7K/8K SoCs.
> 
> Don't we need this also for I2C and UART?

So you posted a patch for I2C as well.

Looking at the cp110-system-controller.c driver (cp110_syscon_common_probe()), 
I see that clock gate #17 (CP110_GATE_MAIN) is automatically enabled when #21 
(CP110_GATE_SLOW_IO) is enabled. So this additional clock specifier should not 
be needed.

Also, as I understand, 'clocks' and 'clock-names' properties are meant to 
describe the clock input from the peripheral device point of view. But gate 
#17 is an internal clock controller gate that is not visible to the SPI master 
or I2C master device.

What problem is this patch meant to solve?

baruch

> > Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> > ---
> >  arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> > index a8af4136dbe7..0ab921861a2f 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> > @@ -257,7 +257,9 @@
> >  			reg = <0x700600 0x50>;
> >  			#address-cells = <0x1>;
> >  			#size-cells = <0x0>;
> > -			clocks = <&CP110_LABEL(clk) 1 21>;
> > +			clock-names = "core", "axi";
> > +			clocks = <&CP110_LABEL(clk) 1 21>,
> > +				 <&CP110_LABEL(clk) 1 17>;
> >  			status = "disabled";
> >  		};
> >  
> > @@ -266,7 +268,9 @@
> >  			reg = <0x700680 0x50>;
> >  			#address-cells = <1>;
> >  			#size-cells = <0>;
> > -			clocks = <&CP110_LABEL(clk) 1 21>;
> > +			clock-names = "core", "axi";
> > +			clocks = <&CP110_LABEL(clk) 1 21>,
> > +				 <&CP110_LABEL(clk) 1 17>;
> >  			status = "disabled";
> >  		};

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -