[PATCH] pinctrl: msm: allow the gpio base to be configurable
Timur Tabi
timur at codeaurora.org
Sun Jan 28 15:29:59 PST 2018
On 1/28/18 5:23 PM, Bjorn Andersson wrote:
> What platform has multiple TLMMs?
>
> [..]
An upcoming one.
>> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
>> index b7b6849625ec..4dc76e15bd14 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
>> @@ -901,7 +901,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
>> return -EINVAL;
>>
>> chip = &pctrl->chip;
>> - chip->base = 0;
> My bad, this should have been -1.
Perhaps, but it's been 0 for a very long time, so I don't want to break
any existing platforms by suddenly relocating all GPIOs across all
Qualcomm platforms.
What do you think about my other idea?
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
More information about the linux-arm-kernel
mailing list