[PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service
Baruch Siach
baruch at tkos.co.il
Tue Jan 9 05:41:35 PST 2018
Hi Stefan,
On Tue, Jan 02, 2018 at 07:49:44PM +0100, Stefan Wahren wrote:
[...]
> > + ret = rpi_firmware_property(gpio->fw, RPI_FIRMWARE_GET_GPIO_CONFIG,
> > + &get, sizeof(get));
> > + if (ret) {
> > + dev_err(gpio->dev,
> > + "Failed to get GPIO %u config (%d)\n", off, ret);
> > + return ret;
> > + }
>
> Shouldn't we also check the in-bound status at get.gpio?
What is the in-bound status value? May you refer me to the documentation?
> And in all the other gpio ops?
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
More information about the linux-arm-kernel
mailing list