[PATCH v2 1/5] pinctrl: imx: use struct imx_pinctrl_soc_info as a const

Gary Bisson gary.bisson at boundarydevices.com
Mon Jan 8 08:48:55 PST 2018


Hi Stefan,

On Sat, Jan 06, 2018 at 03:25:49PM +0100, Stefan Agner wrote:
> For some SoCs the struct imx_pinctrl_soc_info is passed through
> of_device_id.data which is const. Most variables are already const
> or otherwise not written. However, some fields are modified at
> runtime. Move those fields to the dynamically allocated struct
> imx_pinctrl.
> 
> Fixes: b3060044e495 ("pinctrl: freescale: imx7d: make of_device_ids const")
> Cc: Shawn Guo <shawnguo at kernel.org>
> Cc: Arvind Yadav <arvind.yadav.cs at gmail.com>
> Cc: Dong Aisheng <aisheng.dong at nxp.com>
> Cc: Gary Bisson <gary.bisson at boundarydevices.com>
> Signed-off-by: Stefan Agner <stefan at agner.ch>

This is actually more or less a revert of a previous commit:
b28742be4709 pinctrl: imx: remove const qualifier of imx_pinctrl_soc_info

Note that the idea for this commit was to get dt-overlays working and
able to do pinctrl changes using configfs interface to load an overlay
(using Pantelis patch). Not sure where we stand on loading such overlay
from user-space, is it still something that will happen?

Regards,
Gary



More information about the linux-arm-kernel mailing list