[PATCH] arm_pmu: Use disable_irq_nosync when disabling SPI in CPU teardown hook

Will Deacon will.deacon at arm.com
Wed Feb 28 06:27:29 PST 2018


On Wed, Feb 28, 2018 at 03:23:28PM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 28, 2018 at 2:57 PM, Mark Rutland <mark.rutland at arm.com> wrote:
> > On Mon, Feb 26, 2018 at 04:10:56PM +0000, Will Deacon wrote:
> >> Commit 6de3f79112cc ("arm_pmu: explicitly enable/disable SPIs at hotplug")
> >> moved all of the arm_pmu IRQ enable/disable calls to the CPU hotplug hooks,
> >> regardless of whether they are implemented as PPIs or SPIs. This can
> >> lead to us sleeping from atomic context due to disable_irq blocking:
> >
> >> Acked-by: Acked-by: Mark Rutland <mark.rutland at arm.com>
> >
> > I think something went wrong here when you applied the tag. ;)
> 
> In case of respinning:
> Fixes: 6de3f79112cc26bf ("arm_pmu: explicitly enable/disable SPIs at hotplug")

This is already pushed to fixes/core, so I'll leave it up to Catalin whether
he wants to rebase it for that.

Will



More information about the linux-arm-kernel mailing list