[PATCH v2 4/4] pintcrl: support bias-disable of generic and special pins simultaneously

Zhiyong Tao zhiyong.tao at mediatek.com
Mon Feb 26 00:34:02 PST 2018


For generic pins, parameter "arg" is 0 or 1.
For special pins, bias-disable is set by R0R1,
so we need transmited "00" to set bias-disable
When we set "bias-disable" as high-z property,
the parameter should be "MTK_PUPD_SET_R1R0_00".

Signed-off-by: Zhiyong Tao <zhiyong.tao at mediatek.com>
---
 drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 3cf384f..e88ba04 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -301,8 +301,17 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl,
 	 * resistor bit, so we need this special handle.
 	 */
 	if (pctl->devdata->spec_pull_set) {
-		ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin),
-			pin, pctl->devdata->port_align, isup, arg);
+		if (enable) {
+			ret = pctl->devdata->spec_pull_set(
+				mtk_get_regmap(pctl, pin), pin,
+				pctl->devdata->port_align, isup,
+				arg);
+		} else {
+			ret = pctl->devdata->spec_pull_set(
+				mtk_get_regmap(pctl, pin), pin,
+				pctl->devdata->port_align, isup,
+				MTK_PUPD_SET_R1R0_00);
+		}
 		if (!ret)
 			return 0;
 	}
-- 
1.9.1




More information about the linux-arm-kernel mailing list