[PATCH] arm64: dts: ls1046a: drop incomplete memory node

Leo Li leoyang.li at nxp.com
Sun Feb 25 17:33:34 PST 2018



> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo at kernel.org]
> Sent: Saturday, February 24, 2018 3:05 PM
> To: linux-arm-kernel at lists.infradead.org
> Cc: devicetree at vger.kernel.org; Shawn Guo <shawnguo at kernel.org>;
> Mingkai Hu <mingkai.hu at nxp.com>; Shaohui Xie <Shaohui.Xie at nxp.com>;
> Leo Li <leoyang.li at nxp.com>
> Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
> 
> The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the
> dtc warning below.
> 
> Warning (unit_address_vs_reg): Node /memory at 80000000 has a unit name,
> but no reg property
> 
> This is clearly an incomplete memory node.  Let's drop it.  Either a complete
> memory should be added, or bootloader needs to fill the node as a whole.

Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?

> 
> Cc: Mingkai Hu <Mingkai.Hu at nxp.com>
> Cc: Shaohui Xie <Shaohui.Xie at nxp.com>
> Cc: Li Yang <leoyang.li at nxp.com>
> Signed-off-by: Shawn Guo <shawnguo at kernel.org>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 606ea496f24e..cbf4b3e15c17 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -129,10 +129,6 @@
>  		};
>  	};
> 
> -	memory at 80000000 {
> -		device_type = "memory";
> -	};
> -
>  	sysclk: sysclk {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
> --
> 1.9.1




More information about the linux-arm-kernel mailing list