[PATCH v4 35/40] KVM: arm/arm64: Get rid of vgic_elrsr

Julien Grall julien.grall at arm.com
Fri Feb 23 06:44:30 PST 2018

Hi Christoffer,

On 15/02/18 21:03, Christoffer Dall wrote:
> There is really no need to store the vgic_elrsr on the VGIC data
> structures as the only need we have for the elrsr is to figure out if an
> LR is inactive when we save the VGIC state upon returning from the
> guest.  We can might as well store this in a temporary local variable.
> This also gets rid of the endianness conversion in the VGIC save
> function, which is completely unnecessary and would actually result in
> incorrect functionality on big-endian systems, because we are only using
> typed values here and not converting pointers and reading different
> types here.

I can't find any endianness code removed in this code. What did I miss?


Julien Grall

More information about the linux-arm-kernel mailing list