[PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec

Katsuhiro Suzuki suzuki.katsuhiro at socionext.com
Wed Feb 21 04:26:50 PST 2018


Hello Mark,

Thank you for your review.

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Wednesday, February 21, 2018 9:14 PM
> To: Suzuki, Katsuhiro <suzuki.katsuhiro at socionext.com>
> Cc: alsa-devel at alsa-project.org; Rob Herring <robh+dt at kernel.org>; devicetree at vger.kernel.org; Masami Hiramatsu
> <masami.hiramatsu at linaro.org>; Jassi Brar <jaswinder.singh at linaro.org>; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org
> Subject: Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec
> 
> On Wed, Feb 21, 2018 at 01:33:10PM +0900, Katsuhiro Suzuki wrote:
> 
> > +Optional properties:
> > +- VCCA-supply : regulator phandle for the VCCA supply
> > +- VCCP1-supply: regulator phandle for the VCCP1 supply
> > +- VCCP2-supply: regulator phandle for the VCCP2 supply
> 
> These should be documented as mandatory unless the device genuinely
> operates without power which seems unlikely.

Indeed, this IC does not work correctly if VCC power supply is lost.
It's not optional. I'll fix it and send V2.


Regards,
--
Katsuhiro Suzuki








More information about the linux-arm-kernel mailing list