[PATCH] drm/pl111: Fix regression from fbdev CMA helper
Linus Walleij
linus.walleij at linaro.org
Mon Feb 12 07:53:18 PST 2018
On Mon, Feb 12, 2018 at 3:01 PM, Noralf Trønnes <noralf at tronnes.org> wrote:
> Den 12.02.2018 14.42, skrev Noralf Trønnes:
>> Den 12.02.2018 13.40, skrev Linus Walleij:
>>> drm_mode_config_reset(dev);
>>> - drm_fb_cma_fbdev_init(dev, 32, 0);
>>> + drm_fb_cma_fbdev_init(dev, 32, 1);
>>> drm_kms_helper_poll_init(dev);
(...)
> I forgot to look at the change, and I don't understand how this broke
> anything,
My wrong.
I had some old codepaths in my out-of-tree stuff (sorry
the only thing that makes the hardware work...).
I was using the old drm_fbdev_cma_init() which isn't
as helpful as the new drm_fb_cma_fbdev_init() but
as the old function is still there it all just "worked"
except for this...
Theres is some confusion with these similarly named
functions :D
Sorry for the fuzz, I fixed my patch set to use the new
function now.
Let's just drop this patch.
Yours,
Linus Walleij
More information about the linux-arm-kernel
mailing list