[PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node

Simon Horman horms at verge.net.au
Mon Apr 30 00:07:48 PDT 2018


On Thu, Apr 26, 2018 at 04:52:13PM +0200, Niklas Söderlund wrote:
> Hi Simon,
> 
> Thanks for your work.
> 
> On 2018-04-26 12:29:48 +0200, Simon Horman wrote:
> > The gpio_keys node does not have an address and thus does not need
> > address-cells or address size-properties.
> > 
> > This is flagged by dtc as follows:
> >  # make dtbs W=1
> >  arch/arm/boot/dts/r8a7794-silk.dtb: Warning (avoid_unnecessary_addr_size): /soc/video at e6ef0000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> This warning don't seem to match with the change nor the rest of the 
> commit message :-)
> 
> With that addressed and for the whole series:
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas at ragnatech.se>

Thanks!

The fix is:

arch/arm/boot/dts/emev2-kzm9d.dtb: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

> > Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> > ---
> >  arch/arm/boot/dts/emev2-kzm9d.dts | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> > index c238407133bf..0af44b7eadb9 100644
> > --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> > +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> > @@ -34,9 +34,6 @@
> >  
> >  	gpio_keys {
> >  		compatible = "gpio-keys";
> > -		#address-cells = <1>;
> > -		#size-cells = <0>;
> > -
> >  		one {
> >  			debounce-interval = <50>;
> >  			wakeup-source;
> > -- 
> > 2.11.0
> > 
> 
> -- 
> Regards,
> Niklas Söderlund
> 



More information about the linux-arm-kernel mailing list