[RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

Andy Shevchenko andy.shevchenko at gmail.com
Tue Apr 24 09:24:33 PDT 2018


On Tue, Apr 24, 2018 at 10:44 AM, Kirill Marinushkin
<k.marinushkin at gmail.com> wrote:
> In the current implementation, vchi_instance is inited during the first
> call of bcm2835_audio_open_connection(), and is never freed. It causes a
> memory leak when the module `snd_bcm2835` is removed.


> Signed-off-by: Kirill Marinushkin <k.marinushkin at gmail.com>
> Cc: Eric Anholt <eric at anholt.net>
> Cc: Stefan Wahren <stefan.wahren at i2se.com>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Florian Fainelli <f.fainelli at gmail.com>
> Cc: Ray Jui <rjui at broadcom.com>
> Cc: Scott Branden <sbranden at broadcom.com>
> Cc: Andy Shevchenko <andy.shevchenko at gmail.com>
> Cc: bcm-kernel-feedback-list at broadcom.com
> Cc: linux-rpi-kernel at lists.infradead.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: devel at driverdev.osuosl.org
> Cc: linux-kernel at vger.kernel.org

AFAIR I gave you a tag and you again missed it.
Before sending anything just check twice if all prerequisites are fulfilled.

And yes, kbuild bot is right. You need to return known value.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list