brcm, cyw_bt: Add latest Cypress/Murata firmware
Hans de Goede
hdegoede at redhat.com
Mon Apr 23 10:35:46 PDT 2018
Hi,
On 23-04-18 19:17, Ryan Harkin wrote:
>
>
> On 23 April 2018 at 16:56, Hans de Goede <hdegoede at redhat.com <mailto:hdegoede at redhat.com>> wrote:
<snip>
> As said before (sorry) NACK, we really must NOT distribute nvram
> files under generic names.
>
>
> That's fine. But I still think the generic files should be available in the repo for users who want to use them. Having them take an explicit step, like softlinking it to the board specific file, is fine by me. But I believe we should be able to get them if we wish to. At the very least, I would be interested in knowing how my board varies from the generic example given by Cypress/Murata/OEM.
>
> So how about we add the files but either in a sub-dir, and/or with example/generic/sample as the board name? Eg, we could push this file:
>
> brcmfmac43430-sdio-generic.txt
>
> As you suggested, the code could look for brcmfmac43430-sdio-<board name>.txt, if it doesn't find it, fall back to brcmfmac43430-sdio.txt. In this case, brcmfmac43430-sdio-generic.txt will never automatically load.
>
>
> Putting them in linux-firmware as brcmfmac4xxxx-sdio-generic.txt /
> brcmfmac4xxx-pci-generic.txt is fine.
>
>
> I've just started to re-work patch 2/3 and realised that there are already files like "brcmfmac43012-sdio.1LV.txt", where the 1LV is separated by '.' instead of "-", so I figured I'd leave those files as they are and only add ".generic" to the unlabelled/generic ones, unless you think I should add ".generic" to all of them?
>
> Like this:
>
> brcmfmac43012-sdio.1LV.txt
> brcmfmac43012-sdio-generic.txt -> brcmfmac43012-sdio.1LV.txt
> brcmfmac43340-sdio.1BW.txt
> brcmfmac43340-sdio.txt -> brcmfmac43340-sdio.1BW.txt
> brcmfmac43362-sdio.SN8000.txt
> brcmfmac43362-sdio.txt -> brcmfmac43362-sdio.SN8000.txt
> brcmfmac4339-sdio.1CK.txt
> brcmfmac4339-sdio-generic.txt -> brcmfmac4339-sdio.ZP.txt
> brcmfmac4339-sdio.ZP.txt
> brcmfmac43430-sdio.1DX.txt
> brcmfmac43430-sdio.1LN.txt -> brcmfmac43430-sdio.1DX.txt
> brcmfmac43430-sdio.txt -> brcmfmac43430-sdio.1DX.txt
> brcmfmac43455-sdio.1HK.txt
> brcmfmac43455-sdio.1LC.txt
> brcmfmac43455-sdio.1MW.txt
> brcmfmac43455-sdio-generic.txt -> brcmfmac43455-sdio.1MW.txt
> brcmfmac4354-sdio.1BB.txt
> brcmfmac4354-sdio.txt -> brcmfmac4354-sdio.1BB.txt
> brcmfmac4356-pcie.1CX.txt
> brcmfmac4356-pcie-generic.txt -> brcmfmac4356-pcie.1CX.txt
That is fine with me.
Regards,
Hans
More information about the linux-arm-kernel
mailing list