[PATCH] media: s5p-jpeg: don't return a value on a void function
Andrzej Pietrasiewicz
andrzej.p at samsung.com
Sun Apr 22 23:23:33 PDT 2018
Hi,
W dniu 20.04.2018 o 21:10, Jacek Anaszewski pisze:
> Hi Mauro,
>
> Thank you for the patch.
>
> On 04/20/2018 09:01 PM, Mauro Carvalho Chehab wrote:
>> Building this driver on arm64 gives this warning:
>> drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c:430:16: error: return expression in void function
>>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab at s-opensource.com>
>> ---
>> drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c
>> index 0974b9a7a584..0861842b2dfc 100644
>> --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c
>> +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c
>> @@ -425,9 +425,9 @@ unsigned int exynos3250_jpeg_get_int_status(void __iomem *regs)
>> }
>>
>> void exynos3250_jpeg_clear_int_status(void __iomem *regs,
>> - unsigned int value)
>> + unsigned int value)
>> {
>> - return writel(value, regs + EXYNOS3250_JPGINTST);
>> + writel(value, regs + EXYNOS3250_JPGINTST);
>> }
>>
>> unsigned int exynos3250_jpeg_operating(void __iomem *regs)
>>
>
> Reviewed-by: Jacek Anaszewski <jacek.anaszewski at gmail.com>
>
Acked-by: Andrzej Pietrasiewicz <andrzej.p at samsung.com>
More information about the linux-arm-kernel
mailing list