[RFC PATCH 1/3] arm64: stacktrace: Constify stacktrace.h functions

Mark Rutland mark.rutland at arm.com
Fri Apr 20 04:00:00 PDT 2018


On Fri, Apr 20, 2018 at 11:46:17AM +0100, Dave Martin wrote:
> on_accessible_stack() and on_task_stack() shouldn't (and don't)
> modify their task argument, so it can be const.
> 
> This patch adds the appropriate modifiers.
> 
> No functional change.
> 
> Signed-off-by: Dave Martin <Dave.Martin at arm.com>

FWIW:

Acked-by: Mark Rutland <mark.rutland at arm.com>

Mark.

> ---
>  arch/arm64/include/asm/stacktrace.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h
> index 902f9ed..63c0379 100644
> --- a/arch/arm64/include/asm/stacktrace.h
> +++ b/arch/arm64/include/asm/stacktrace.h
> @@ -50,7 +50,8 @@ static inline bool on_irq_stack(unsigned long sp)
>  	return (low <= sp && sp < high);
>  }
>  
> -static inline bool on_task_stack(struct task_struct *tsk, unsigned long sp)
> +static inline bool on_task_stack(struct task_struct const *tsk,
> +				 unsigned long sp)
>  {
>  	unsigned long low = (unsigned long)task_stack_page(tsk);
>  	unsigned long high = low + THREAD_SIZE;
> @@ -76,7 +77,8 @@ static inline bool on_overflow_stack(unsigned long sp) { return false; }
>   * We can only safely access per-cpu stacks from current in a non-preemptible
>   * context.
>   */
> -static inline bool on_accessible_stack(struct task_struct *tsk, unsigned long sp)
> +static inline bool on_accessible_stack(struct task_struct const *tsk,
> +				       unsigned long sp)
>  {
>  	if (on_task_stack(tsk, sp))
>  		return true;
> -- 
> 2.1.4
> 



More information about the linux-arm-kernel mailing list