[PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset
Sinan Kaya
okaya at codeaurora.org
Thu Apr 19 12:56:23 PDT 2018
The infiniband adapter might be connected to a PCI hotplug slot. Performing
secondary bus reset on a hotplug slot causes PCI link up/down interrupts.
Hotplug driver removes the device from system when a link down interrupt
is observed and performs re-enumeration when link up interrupt is observed.
This conflicts with what this code is trying to do. Try secondary bus reset
only if pci_reset_slot() fails/unsupported.
Signed-off-by: Sinan Kaya <okaya at codeaurora.org>
---
drivers/infiniband/hw/hfi1/pcie.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c
index 83d66e8..75f49e3 100644
--- a/drivers/infiniband/hw/hfi1/pcie.c
+++ b/drivers/infiniband/hw/hfi1/pcie.c
@@ -908,7 +908,8 @@ static int trigger_sbr(struct hfi1_devdata *dd)
* delay after a reset is required. Per spec requirements,
* the link is either working or not after that point.
*/
- pci_reset_bridge_secondary_bus(dev->bus->self);
+ if (pci_reset_slot(dev->slot))
+ pci_reset_bridge_secondary_bus(dev->bus->self);
return 0;
}
--
2.7.4
More information about the linux-arm-kernel
mailing list