[PATCH] ARM: dts: Restructure Vexpress motherboard includes

Robin Murphy robin.murphy at arm.com
Tue Apr 17 06:03:41 PDT 2018


On 17/04/18 13:43, Linus Walleij wrote:
[...]
>>> +/ {
>>> +       smb at 8000000 {
>>
>>
>> Nit: Surely "&smb {", given that you've already gone to the length of
>> labelling it in the includers? (plus that should also avoid the need to
>> reindent)
> 
> I tried that and it didn't work.
> 
> I guess it is because the includes go in the reverse parsing order, this
> file is included into the main DTS.
> 
> If the &smb was referenced from the DTS to the definition in
> the DTSI, it would work fine.
> 
> However the reverse, &smb before the node has been defined
> (it's in the DTS) doesn't work and seems to reflect to top-to-bottom
> parsing scheme.

Ah, right, I'd overlooked that the funky VExpress "one board, many SoCs" 
setup makes this inclusion backwards compared to the typical usage. I 
suppose the way to make it more regular would be to add an extra level 
of indirection, i.e. vexpress-<tile>.dts as just:

#include vexpress-<tile>.dtsi
#include vexpress-motherboard.dtsi

which in no way seems worth the bother. Let's keep this as-is then 
(although possibly that means we don't really need the smb labels at all?)

Thanks,
Robin.



More information about the linux-arm-kernel mailing list