[PATCH v2 09/13] locking/qspinlock: Merge struct __qspinlock into struct qspinlock

Waiman Long longman at redhat.com
Wed Apr 11 12:13:16 PDT 2018


On 04/11/2018 02:01 PM, Will Deacon wrote:
> struct __qspinlock provides a handy union of fields so that
> subcomponents of the lockword can be accessed by name, without having to
> manage shifts and masks explicitly and take endianness into account.
>
> This is useful in qspinlock.h and also potentially in arch headers, so
> move the struct __qspinlock into struct qspinlock and kill the extra
> definition.
>
> Cc: Peter Zijlstra <peterz at infradead.org>
> Cc: Ingo Molnar <mingo at kernel.org>
> Acked-by: Boqun Feng <boqun.feng at gmail.com>
> Signed-off-by: Will Deacon <will.deacon at arm.com>

I think you are using the new qspinlock structure in some of your
earlier patches like patch 4. So you may want to move that earlier in
the series to avoid bisection problem.

Cheers,
Longman



More information about the linux-arm-kernel mailing list