[PATCH v4 2/7] clk: meson: migrate to devm_of_clk_add_hw_provider API
Jerome Brunet
jbrunet at baylibre.com
Mon Apr 9 05:03:45 PDT 2018
On Sun, 2018-04-08 at 11:19 +0800, Yixun Lan wrote:
> There is a protential memory leak, as of_clk_del_provider is
> never called if of_clk_add_hw_provider has been executed.
> Fix this by using devm variant API.
>
> Suggested-by: Stephen Boyd <sboyd at kernel.org>
> Signed-off-by: Yixun Lan <yixun.lan at amlogic.com>
Please make this the 1st patch of the series and add the proper fixes tag.
> ---
> drivers/clk/meson/meson-aoclk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/meson-aoclk.c b/drivers/clk/meson/meson-aoclk.c
> index 14862c22e20d..14a1e46a4de6 100644
> --- a/drivers/clk/meson/meson-aoclk.c
> +++ b/drivers/clk/meson/meson-aoclk.c
> @@ -78,6 +78,6 @@ int meson_aoclkc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - return of_clk_add_hw_provider(dev->of_node, of_clk_hw_onecell_get,
> + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
> (void *) data->hw_data);
> }
More information about the linux-arm-kernel
mailing list