[PATCH] ARM: dts: omap3-beagle-xm: Add fixed 26MHz clock as fck for twl

[Peter Ujfalusi]

On 2018-04-05 16:15, Peter Ujfalusi wrote:
> 
> 
> On 2018-04-05 14:52, Peter Ujfalusi wrote:
>> The board uses 26MHz oscillator for the twl4030 HFCLK.
>> This way we will not depend on the bootloader to configure the
>> CFG_BOOT:HFCLK_FREQ
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
>> ---
>> Hi,
>>
>> there might be other boards (all omap3 boards with twl4030?) which uses the same
>> setup, but I only have schematics for beagle-xm.
>>
>> In order for the driver to actually use the clock the 
>> [PATCH] mfd: twl-core: Fix clock initialization
>> need to be applied. W/o the twl-core patch the clock is just ignored.
>>
>> Regards,
>> Peter
>>
>>  arch/arm/boot/dts/omap3-beagle-xm.dts | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
>> index 0349fcc9dc26..d80587de0bbf 100644
>> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
>> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
>> @@ -30,6 +30,13 @@
>>  		ethernet = ðernet;
>>  	};
>>  
>> +	/* fixed 26MHz oscillator */
>> +	hfclk_26m: oscillator {
>> +		#clock-cells = <0>;
>> +		compatible = "fixed-clock";
>> +		clock-frequency = <26000000>;
>> +	};
>> +
>>  	leds {
>>  		compatible = "gpio-leds";
>>  
>> @@ -274,6 +281,9 @@
>>  		interrupts = <7>; /* SYS_NIRQ cascaded to intc */
>>  		interrupt-parent = <&intc>;
>>  
>> +		clocks = <&hfclk_26m>;
>> +		clock-names = "fck";
> 
> I wonder if we should rename this to hfclk...
> The DT documentation does not mention it and afaik it is not specified
> in DT files either.
> 
> After all it is the HFCLK clock for the twl4030.

We should not as it would break compatibility with stable kernels where
the code expects 'fck' and not hfclk.

> 
> I'm fine keeping it as 'fck' but it looks a bit weird.
> 
>> +
>>  		twl_audio: audio {
>>  			compatible = "ti,twl4030-audio";
>>  			codec {
>>
> 
> - Péter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki