[PATCH] ARM: davinci: dm644x: remove unnecessary postcore_initcall()

Sekhar Nori nsekhar at ti.com
Wed Apr 4 23:10:17 PDT 2018


On Wednesday 04 April 2018 09:22 PM, David Lechner wrote:
>>
>> --- a/arch/arm/mach-davinci/board-sffsdr.c
>> +++ b/arch/arm/mach-davinci/board-sffsdr.c
>> @@ -133,6 +133,12 @@ static void __init davinci_sffsdr_map_io(void)
>>   static __init void davinci_sffsdr_init(void)
>>   {
>>       struct davinci_soc_info *soc_info = &davinci_soc_info;
>> +    int ret;
>> +
>> +    ret = dm644x_init_devices();
>> +    if (ret)
>> +        pr_warn("%s: dm644x_init_devices() failed: %d\n",
>> +            __func__, ret);
> 
> dm644x_init_devices() already prints a warning in all failure cases, so
> printing another warning seems a bit redundant. It is probably OK to just
> ignore the return value here and in the similar uses above.

Alright, will fix and send v2.

Regards,
Sekhar



More information about the linux-arm-kernel mailing list