[PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

Andrew Lunn andrew at lunn.ch
Wed Sep 27 07:02:10 PDT 2017


Hi Corentin

> +Required properties for the mdio-mux node:
> +  - compatible = "mdio-mux"

This is too generic. Please add a more specific compatible for this
particular mux. You can keep "mdio-mux", since that is what the MDIO
subsystem will look for.

> +Required properties of the integrated phy node:
>  - clocks: a phandle to the reference clock for the EPHY
>  - resets: a phandle to the reset control for the EPHY
> +- phy-is-integrated

So the last thing you said is that the mux is not the problem
here. Something else is locking up. Did you discover what?

I really would like phy-is-integrated to go away.

  Andrew



More information about the linux-arm-kernel mailing list