[PATCH v4 2/4] thermal: add brcmstb AVS TMON driver

[Florian Fainelli]

On 09/25/2017 08:02 PM, Zhang, Rui wrote:
> Hi, Florian,
> 
> This patch set was dropped in the last minute because of this discussion
> https://patchwork.kernel.org/patch/9936325/
> as I don’t want to rebase the patch before sending the pull request.

Ah, you wanted to squash that patch into the initial submission?

> 
> I don’t think we can make it for 4.14.
> Eduardo will be back and pick the soc patches for 4.15.

I assume you would want to get that particular patch squashed into a
clean submission targeting 4.15 now, right?

Thanks

> 
> Thanks,
> rui
> 
> 
> 
> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli at gmail.com] 
> Sent: Monday, September 25, 2017 5:11 AM
> To: Zhang, Rui <rui.zhang at intel.com>; Rafał Miłecki <rafal at milecki.pl>
> Cc: Markus Mayer <code at mmayer.net>; Eduardo Valentin <edubezval at gmail.com>; Rob Herring <robh+dt at kernel.org>; Mark Rutland <mark.rutland at arm.com>; Doug Berger <opendmb at gmail.com>; Brian Norris <computersforpeace at gmail.com>; Gregory Fong <gregory.0xf0 at gmail.com>; Russell King <linux at armlinux.org.uk>; Catalin Marinas <catalin.marinas at arm.com>; Will Deacon <will.deacon at arm.com>; Arnd Bergmann <arnd at arndb.de>; Olof Johansson <olof at lixom.net>; Broadcom Kernel List <bcm-kernel-feedback-list at broadcom.com>; Power Management List <linux-pm at vger.kernel.org>; Device Tree List <devicetree at vger.kernel.org>; ARM Kernel List <linux-arm-kernel at lists.infradead.org>; Linux Kernel Mailing List <linux-kernel at vger.kernel.org>; Markus Mayer <mmayer at broadcom.com>
> Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
> Importance: High
> 
> Le 08/14/17 à 23:48, Zhang Rui a écrit :
>> On Tue, 2017-08-15 at 08:42 +0200, Rafał Miłecki wrote:
>>> On 2017-08-15 08:08, Zhang Rui wrote:
>>>>
>>>>>
>>>>> diff --git a/drivers/thermal/broadcom/Kconfig
>>>>> b/drivers/thermal/broadcom/Kconfig
>>>>> index 42c098e..c106a15 100644
>>>>> --- a/drivers/thermal/broadcom/Kconfig
>>>>> +++ b/drivers/thermal/broadcom/Kconfig
>>>>> @@ -6,6 +6,13 @@ config BCM2835_THERMAL
>>>>>  	help
>>>>>  	  Support for thermal sensors on Broadcom bcm2835 SoCs.
>>>>>  
>>>>> +config BRCMSTB_THERMAL
>>>>> +	tristate "Broadcom STB AVS TMON thermal driver"
>>>>> +	depends on ARCH_BRCMSTB || COMPILE_TEST
>>>>> +	help
>>>>> +	  Enable this driver if you have a Broadcom STB SoC and
>>>>> would like
>>>>> +	  thermal framework support.
>>>>> +
>>>> I don't understand why I got the following checkpatch warning
>>>>
>>>> WARNING: please write a paragraph that describes the config symbol 
>>>> fully
>>>> #73: FILE: drivers/thermal/broadcom/Kconfig:9:
>>>> +config BRCMSTB_THERMAL
>>>>
>>>> I didn't see this for other Kconfig changes.
>>> It's because your help message is only 2 lines long (instead of 3).
>>>
>>> Some (many?) maintainers aren't pedantic about that, a common sense 
>>> should be applied ;)
>>
>> thanks for explaining.
>> Patch 1 and 2 queued for next merge window.
> 
> Humm, I don't see this driver in your latest 4.14 pull request to Linus, so what happened here exactly? Can we expect this driver to be submitted for 4.14 or we just happened to have missed this window now?
> --
> Florian
> 

-- 
Florian