[PATCH 5/9] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports

[Baruch Siach]

Hi Antoine,

On Mon, Sep 18, 2017 at 09:58:10AM +0200, Antoine Tenart wrote:
> This patch adds comphy phandles to the Ethernet ports in the mcbin
> device tree. The comphy is used to configure the serdes PHYs used by
> these ports.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart at free-electrons.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> index acf5c7d16d79..9a3b4a1fd445 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> @@ -223,6 +223,7 @@
>  &cpm_eth0 {
>  	status = "okay";
>  	phy = <&phy0>;
> +	phys = <&cpm_comphy4 0>;
>  	phy-mode = "10gbase-kr";

Since the 'phys' generic PHY property is unrelated to the 'phy*' Ethernet PHY 
properties that surround it, its location might be confusing. I think it 
should appear below those two other properties like you did below ...

>  };
>  
> @@ -258,6 +259,7 @@
>  &cps_eth0 {
>  	status = "okay";
>  	phy = <&phy8>;
> +	phys = <&cps_comphy4 0>;
>  	phy-mode = "10gbase-kr";

... not here ...

>  };
>  
> @@ -266,6 +268,7 @@
>  	status = "okay";
>  	phy = <&ge_phy>;
>  	phy-mode = "sgmii";
> +	phys = <&cps_comphy0 1>;

... but here.

See also upstream commits 9a94b3a4bdfdb40 (dt-binding: phy: don't confuse with 
Ethernet phy properties) and c43593d81ab59b (dt-bindings: net: don't confuse 
with generic PHY property).

>  };
>  
>  &cps_pinctrl {

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -