[PATCH v8 02/11] sparc64/mm: setting fields in deferred pages
pasha.tatashin at oracle.com
Thu Sep 14 15:35:08 PDT 2017
Without deferred struct page feature (CONFIG_DEFERRED_STRUCT_PAGE_INIT),
flags and other fields in "struct page"es are never changed prior to first
initializing struct pages by going through __init_single_page().
With deferred struct page feature enabled there is a case where we set some
fields prior to initializing:
When register_page_bootmem_info() is called only non-deferred struct pages
are initialized. But, this function goes through some reserved pages which
might be part of the deferred, and thus are not yet initialized.
.. setting fields here ..
such as: page->freelist = (void *)type;
init_reserved_page() <- Only if this is deferred reserved page
memset(0) <-- Loose the set fields here
We end-up with similar issue as in the previous patch, where currently we
do not observe problem as memory is zeroed. But, if flag asserts are
changed we can start hitting issues.
Also, because in this patch series we will stop zeroing struct page memory
during allocation, we must make sure that struct pages are properly
initialized prior to using them.
The deferred-reserved pages are initialized in free_all_bootmem().
Therefore, the fix is to switch the above calls.
Signed-off-by: Pavel Tatashin <pasha.tatashin at oracle.com>
Reviewed-by: Steven Sistare <steven.sistare at oracle.com>
Reviewed-by: Daniel Jordan <daniel.m.jordan at oracle.com>
Reviewed-by: Bob Picco <bob.picco at oracle.com>
Acked-by: David S. Miller <davem at davemloft.net>
arch/sparc/mm/init_64.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
index b2ba410b26f4..078f1352736e 100644
@@ -2539,9 +2539,15 @@ void __init mem_init(void)
high_memory = __va(last_valid_pfn << PAGE_SHIFT);
+ /* Must be done after boot memory is put on freelist, because here we
+ * might set fields in deferred struct pages that have not yet been
+ * initialized, and free_all_bootmem() initializes all the reserved
+ * deferred pages for us.
* Set up the zero page, mark it reserved, so that page count
* is not manipulated when freeing the page from user ptes.
More information about the linux-arm-kernel