[PATCH] clk: bulk: call of_clk_get() when id is NULL
A.s. Dong
aisheng.dong at nxp.com
Sun Sep 10 21:51:28 PDT 2017
Hi Shawn,
> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd at codeaurora.org]
> Sent: Thursday, August 31, 2017 1:27 PM
> To: A.s. Dong
> Cc: Shawn Guo; Michael Turquette; linux-clk at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; Shawn Guo
> Subject: Re: [PATCH] clk: bulk: call of_clk_get() when id is NULL
>
> On 08/30, A.s. Dong wrote:
[...]
> > Flags may be better used for extending per clk feature support in the
> future.
> >
> > IMHO how about implement a of_clk_bulk_get() to handle this issue as
> > we already have a of_clk_get?
> > e.g.
> >
> > int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
> > struct clk_bulk_data *clks) {
> > for (i = 0; i < num_clks; i++) {
> > clks[i].clk = of_clk_get(dev, clks[i].id); ...
> >
> > }
> >
> > Then it's less intrusive.
> >
>
> This looks ok too. Go ahead and send this version instead.
>
I did not see you send a update version.
If you will not do it, would you mind me to help send it with a Reported-by: tag from you?
Regards
Dong Aisheng
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
More information about the linux-arm-kernel
mailing list